Skip to content

Commit

Permalink
Test that assert_not returns true. Use assert_raises instead of doing…
Browse files Browse the repository at this point in the history
… begin/rescue/else.
  • Loading branch information
jeremy committed Dec 29, 2012
1 parent 54a6518 commit 8a130ec
Showing 1 changed file with 7 additions and 17 deletions.
24 changes: 7 additions & 17 deletions activesupport/test/test_test.rb
Expand Up @@ -16,24 +16,14 @@ def decrement
end

def test_assert_not
assert_not nil
assert_not false

begin
assert_not true
rescue Exception => e
assert_equal 'Expected true to be nil or false', e.message
else
fail 'assert_not true should fail'
end
assert_equal true, assert_not(nil)
assert_equal true, assert_not(false)

begin
assert_not true, 'custom'
rescue Exception => e
assert_equal 'custom', e.message
else
fail 'assert_not true should fail'
end
e = assert_raises(MiniTest::Assertion) { assert_not true }
assert_equal 'Expected true to be nil or false', e.message

e = assert_raises(MiniTest::Assertion) { assert_not true, 'custom' }
assert_equal 'custom', e.message
end

def test_assert_no_difference
Expand Down

0 comments on commit 8a130ec

Please sign in to comment.