Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skin Integration - img path is wrong #186

Closed
wants to merge 1 commit into from
Closed

Conversation

Ilia
Copy link
Contributor

@Ilia Ilia commented Dec 31, 2014

Fixed this as well as I could, there is probably a better way - looking for feedback.

Background:
Images stopped showing in my skin, the path i was getting was:
-> //images.primewire.ag/thumbs/2755784_The_Interview_2014.jpg
skin was looking for:
-> http://images.primewire.ag/thumbs/2755784_The_Interview_2014.jpg

@tknorris
Copy link
Contributor

tknorris commented Jan 1, 2015

I need to double check this. It looks like all the image paths on PW changed to be like this. If so, we need to put this down in pw_scraper so that all images are correct rather than in this code. I'll look at it later tonight.

@Ilia
Copy link
Contributor Author

Ilia commented Jan 1, 2015

Not sure about the scraper, the images inside the plugin itself are fine

Regards,
Ilia Mogilevsky

On 1 Jan 2015, at 1:03 pm, tknorris notifications@github.com wrote:

I need to double check this. It looks like all the image paths on PW
changed to be like this. If so, we need to put this down in pw_scraper so
that all images are correct rather than in this code. I'll look at it later
tonight.


Reply to this email directly or view it on GitHub
#186 (comment).

@tknorris
Copy link
Contributor

tknorris commented Jan 1, 2015

I don't think so. I think the ones returned by metahandler are still fine, but all the ones coming back from PW are broken.

Edit: Double checked and they are all broken. So, I'll close this PR and do a new one to fix it for everything in the addon.

@tknorris tknorris closed this Jan 1, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants