New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error after Pimatic update to version 0.9.44 #6

Closed
mathiaslehmann opened this Issue Feb 4, 2019 · 6 comments

Comments

Projects
None yet
3 participants
@mathiaslehmann
Copy link

mathiaslehmann commented Feb 4, 2019

Hello, I have a problem with the Phone Plugin after the Pimatic update to version 0.9.44. Here is my log at startup. An error “Cannot find module ‘i18n’” appears. Can someone help here? Thank you.

18:25:45.550 [pimatic] info: Loading plugin: “pimatic-phone” (0.9.6)
18:25:45.662 [pimatic] error: Cannot find module ‘i18n’

@michbeck100

This comment has been minimized.

Copy link
Contributor

michbeck100 commented Feb 5, 2019

Did you try to remove the plugin and reinstall? It might install i18n properly then. Don't forget to save your config though.

@mathiaslehmann

This comment has been minimized.

Copy link
Author

mathiaslehmann commented Feb 5, 2019

Hello, I've tried that now. The error remains unfortunately.

@bstrebel

This comment has been minimized.

Copy link
Owner

bstrebel commented Feb 6, 2019

Hi, at the moment I'm not able to update my development environment to 0.9.44. It would be great, if @michbeck100 could help with the module loading problem.

@michbeck100

This comment has been minimized.

Copy link
Contributor

michbeck100 commented Feb 6, 2019

@bstrebel Why are you using 18n at all? I don't see that you have any translations in the project, and pimatic core doesn't include translations for pimatic-phone either.

michbeck100 added a commit to michbeck100/pimatic-phone that referenced this issue Feb 11, 2019

@michbeck100

This comment has been minimized.

Copy link
Contributor

michbeck100 commented Feb 11, 2019

#7 solves the issues

bstrebel added a commit that referenced this issue Feb 12, 2019

Merge pull request #7 from michbeck100/master
#6 - Move to i18n-pimatic
@bstrebel

This comment has been minimized.

Copy link
Owner

bstrebel commented Feb 16, 2019

Published 0.9.7 with fix from @michbeck100

@bstrebel bstrebel closed this Feb 16, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment