Add context parameter to ChainTracker interface #197
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds context.Context parameter to IsValidRootForHeight method to enable proper cancellation and timeout support for API calls. This is a best practice for operations that make HTTP requests. Breaking change: All ChainTracker implementations and callers updated to include context parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adds
context.Contextparameter toChainTracker.IsValidRootForHeightmethod to enable proper cancellation and timeout support for API calls.Changes
Breaking Change
This is a breaking change that requires callers to pass context when using ChainTracker methods. Enables better control over HTTP request timeouts and cancellation.