From df60380e256eea9e3a9fcd9e2da608fb12feeb1e Mon Sep 17 00:00:00 2001 From: defiant1708 Date: Thu, 21 Aug 2025 01:12:03 +0900 Subject: [PATCH] Refactor SimplifiedHTTPTransport: improve error handling and payload processing --- bsv/auth/transports/simplified_http_transport.py | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/bsv/auth/transports/simplified_http_transport.py b/bsv/auth/transports/simplified_http_transport.py index d1a514c..ca8f177 100644 --- a/bsv/auth/transports/simplified_http_transport.py +++ b/bsv/auth/transports/simplified_http_transport.py @@ -22,8 +22,8 @@ def send(self, ctx: Any, message: AuthMessage) -> Optional[Exception]: return Exception("No handler registered") try: if getattr(message, 'message_type', None) == 'general': - # payloadをHTTPリクエストとしてデシリアライズ(簡易実装) - # ここではpayloadはJSONでリクエスト情報が入っていると仮定 + # Deserialize the payload into HTTP request parameters (simplified implementation) + # Here we assume the payload is JSON containing the request information import json try: req_info = json.loads(message.payload.decode('utf-8')) @@ -35,7 +35,7 @@ def send(self, ctx: Any, message: AuthMessage) -> Optional[Exception]: body = req_info.get('body', None) url = self.base_url + path resp = self.client.request(method, url, headers=headers, data=body) - # レスポンスをAuthMessageでラップしてコールバック + # Wrap the response in an AuthMessage and trigger callbacks resp_payload = { 'status_code': resp.status_code, 'headers': dict(resp.headers), @@ -48,7 +48,7 @@ def send(self, ctx: Any, message: AuthMessage) -> Optional[Exception]: ) self._notify_handlers(ctx, response_msg) return None - # 通常のAuthMessage送信 + # Send a standard AuthMessage url = self.base_url if getattr(message, 'message_type', None) != 'general': url = self.base_url.rstrip('/') + '/.well-known/auth' @@ -63,7 +63,7 @@ def send(self, ctx: Any, message: AuthMessage) -> Optional[Exception]: response_msg = AuthMessage(**resp_data) self._notify_handlers(ctx, response_msg) except Exception: - pass # 応答がAuthMessageでなければ無視 + pass # Ignore the response if it is not an AuthMessage return None except Exception as e: return Exception(f"Failed to send AuthMessage: {e}")