Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rspec2 not being required. #68

Merged
merged 6 commits into from Mar 15, 2013
Merged

Rspec2 not being required. #68

merged 6 commits into from Mar 15, 2013

Conversation

james2m
Copy link
Contributor

@james2m james2m commented Sep 22, 2011

rr.rb wasn't requiring the rspec2 adapter.

@voxik
Copy link

voxik commented Jan 23, 2012

Would be nice if you could merge it.

@james2m
Copy link
Contributor Author

james2m commented Jan 23, 2012

In the mean time, my master branch https://github.com/james2m/rr has the latest from btakita's master with the Rspec2 branch merged. I've been using this for several projects with no issues.

@sujoyg
Copy link

sujoyg commented Feb 2, 2012

@james2m Did you release a gem with the fix for rspec2 matchers?

@james2m
Copy link
Contributor Author

james2m commented Feb 2, 2012

@sujoyg No I didn't release a gem, I'm just using my fork by specifying

gem 'rr', :git => 'https://github.com/james2m/rr'

In my Gemfile

mcmire added a commit that referenced this pull request Mar 15, 2013
Rspec2 not being required.

Conflicts:
	Gemfile
	spec/spec_helper.rb
@mcmire mcmire merged commit 12896e1 into btakita:master Mar 15, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants