Proper error checks for applesign

btcpayserver · Dec 5, 2019 · 5112fb6 · 5112fb6
1 parent da8f431
commit 5112fb6
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/Build/travis/applesign.sh b/Build/travis/applesign.sh
@@ -49,8 +49,12 @@ mkdir -p dist
 download_url="https://$AZURE_ACCOUNT_NAME.blob.core.windows.net/$AZURE_STORAGE_CONTAINER/$DIRECTORY_NAME/$dmg_file"
 echo "Download $download_url to dist/$dmg_file"
 wget -qO "dist/$dmg_file" "https://$AZURE_ACCOUNT_NAME.blob.core.windows.net/$AZURE_STORAGE_CONTAINER/$DIRECTORY_NAME/$dmg_file"
+echo "Downloaded"
 cd dist
-echo "$APPLE_DEV_ID_CERT" | base64 --decode > dev.p12
+if ! (echo "$APPLE_DEV_ID_CERT" | base64 --decode > dev.p12); then
+    echo "Could not decode APPLE_DEV_ID_CERT from base64"
+    exit 1
+fi
 
 dmg_file_writable="$dmg_file.writable.dmg"
 

diff --git a/Build/travis/build.sh b/Build/travis/build.sh
@@ -13,7 +13,6 @@ if [[ "$TRAVIS_TAG" ]]; then
         echo "The tagged version on travis ($travis_version) is different from the csproj ($csproj_version)"
         exit 1
     fi
-    exit 0
 fi
 
 if ! [[ "$AZURE_STORAGE_CONNECTION_STRING" ]] || ! [[ "$AZURE_STORAGE_CONTAINER" ]]; then