Missing CancellationTokens for some methods in ILightningClient

[konak]

Some methods in ILightningClient do not have CancellationToken as parameter:

    Task<BitcoinAddress> GetDepositAddress();
    Task<ConnectionResult> ConnectTo(NodeInfo nodeInfo);
    Task CancelInvoice(string invoiceId);

Is that Ok ? Because in some cases they can became an issue for client and backend responsiveness.

[dennisreimann]

@Kukks Is there a special reason why we don't have them for ConnectTo and GetDepositAddress? For CancelInvoice we are explicit and passing a CancellationToken.None to the underlying implementations, but for the others we are just omitting the CT, though I think we should pass it.

[Kukks]

@Kukks Is there a special reason why we don't have them for ConnectTo and GetDepositAddress? For CancelInvoice we are explicit and passing a CancellationToken.None to the underlying implementations, but for the others we are just omitting the CT, though I think we should pass it.

ack for adding them

[dennisreimann]

@Kukks I can do that next — what about the CancelInvoice one? Are we omitting it consciously or shall it get added too?

[Kukks]

Go for it

…

On Fri, May 13, 2022, 13:46 d11n ***@***.***> wrote: @Kukks <https://github.com/Kukks> I can do that next — what about the CancelInvoice one? Are we omitting it consciously or shall it get added too? — Reply to this email directly, view it on GitHub <#68 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAN357UVZZHFSVIBCFSU5V3VJY6JNANCNFSM5TUDFTFA> . You are receiving this because you were mentioned.Message ID: ***@***.***>

[NicolasDorier]

Pushed new packages.