Shopify app - deprecated API calls

[rolandschellhorn]

Hello guys, I got a message from Shopify which I just copy here:

"Hello there,

One or more of your apps have made deprecated API calls in the last 30 days. Support for this version will be removed on April 1, 2023. Please update the apps listed below to API version 2022-07 or later to ensure they continue to function correctly.

Store: ...

App: BtcPayServer
Breaking Changes:

The origin_location and destination_location fields on line items have been deprecated from Admin REST API's Order resource. View change.
The total_price_usd field on Order has been deprecated from the Admin REST API's Order resource. View change.
Multi Managed Inventory introduced a breaking change to the Order.line_items.fulfillment_service field. This field is due to be deprecated from both the Admin GraphQL and the Admin REST APIs. When using the GraphQL API, consider using FulfillmentOrder.assigned_location. When using the REST API, see FulfillmentOrder.assigned_location. View change.
Some customer fields have been deprecated from the Admin REST API's Order resource. View change.

To learn how to update your apps, read the private app versioning deprecation guide. If you still have questions, chat with us in the API forums or contact us via Support.

Regards,
Shopify Apps Team"

[iggy097]

I just received the same email - came here to post this.

[pavlenex]

@Kukks @rockstardev Is there something we could do about this?

[iggy097]

Just to confirm - it seems this has not worked since the beginning of the year. When a user tries to checkout with BTC Pay Server - no window opens up to make payment and no invoice is created.
Will this be fixed?

[rolandschellhorn]

Just to confirm - it seems this has not worked since the beginning of the year. When a user tries to checkout with BTC Pay Server - no window opens up to make payment and no invoice is created. Will this be fixed?

@iggy097 - regarding of this upcoming api change - your btcpayserver checkout should still work as expected

[iggy097]

Just to confirm - it seems this has not worked since the beginning of the year. When a user tries to checkout with BTC Pay Server - no window opens up to make payment and no invoice is created. Will this be fixed?

@iggy097 - regarding of this upcoming api change - your btcpayserver checkout should still work as expected

I have had many users try to checkout this and my last invoice was December - could this be due to updating BTCPayserver to a new version? It was previously working fine.

[rolandschellhorn]

Just to confirm - it seems this has not worked since the beginning of the year. When a user tries to checkout with BTC Pay Server - no window opens up to make payment and no invoice is created. Will this be fixed?

@iggy097 - regarding of this upcoming api change - your btcpayserver checkout should still work as expected

I have had many users try to checkout this and my last invoice was December - could this be due to updating BTCPayserver to a new version? It was previously working fine.

I guess you should open a new issue and share more details about it.

[iggy097]

Just to confirm - it seems this has not worked since the beginning of the year. When a user tries to checkout with BTC Pay Server - no window opens up to make payment and no invoice is created. Will this be fixed?

@iggy097 - regarding of this upcoming api change - your btcpayserver checkout should still work as expected

I have had many users try to checkout this and my last invoice was December - could this be due to updating BTCPayserver to a new version? It was previously working fine.

I guess you should open a new issue and share more details about it.

I was able to get it up and running again by setting it up from scratch again (but yes the original Email you posted about still stands)

[pavlenex]

@Kukks Can you prioritize this, it seems quite a few people are reporting Shopify isn't reliable. We should at least test the current integration and ensure it works, and then try to proactively adapt to the upcoming changes.

[ndeet]

Here is the offical changelog: https://shopify.dev/changelog/property-deprecations-in-the-admin-api-order-and-lineitem-resource

[bolatovumar]

Took a quick look through the code and couldn't find usage of any of the deprecated fields they are mentioning. They are not saying what exactly our app uses that is deprecated which means we have to hunt around to find out.

[bolatovumar]

The closest thing I could find is that we are using the total_price field while they are deprecating total_price_usd.

[bolatovumar]

I wonder if it's because we are using the Order resource by requesting a filtered version of its fields so we technically could be using one of the deprecated fields on this resource and Shopify considers this a good enough reason to warn us?

Specifically I'm thinking of this line:

btcpayserver/BTCPayServer/Plugins/Shopify/ShopifyApiClient.cs

Line 112 in 808949a

$"orders/{orderId}.json?fields=id,order_number,total_price,total_outstanding,currency,presentment_currency,transactions,financial_status");

[pavlenex]

Thanks for investigating @bolatovumar

So is there something we should do to cater these changes, or was this a false alarm? @Kukks @bolatovumar ?

[bolatovumar]

@pavlenex it looks like a false alarm to me. My hypothesis is that Shopify sees that we use Order resource and assumes we use one of the deprecated fields from it because whatever they use for this analysis doesn't go into enough detail to see that we don't use the deprecated fields. I might be wrong but that's my thinking.

[pavlenex]

Ok, let's re-open if problems occur in the future, closing for now.