Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet UI: Improve views #1763

Merged
merged 3 commits into from Aug 3, 2020
Merged

Conversation

dennisreimann
Copy link
Member

@dennisreimann dennisreimann commented Jul 23, 2020

Again, some improvements for the wallet views. Mostly properly aligned things, set the correct widths for inputs and minor text updates.

Derivation scheme

Made the input a textarea, so that the full scheme is visible at once. Also removed this part of the text, that no one seems to remember what it was for :D

Please, verify that you are generating the right addresses by clicking on 'Check ExtPubKey'

derivation-scheme

Send

Mostly alignment stuff and responsive improvements here …

send-plain

send-coin-selection

Receive

Mostly alignment stuff and responsive improvements here …

receive

Rescan

Input sizes and responsive improvements.

rescan

Settings

Input sizes and responsive improvements.

settings

@dennisreimann dennisreimann requested a review from Kukks Jul 23, 2020
BTCPayServer/Views/Wallets/WalletSend.cshtml Outdated Show resolved Hide resolved
@NicolasDorier
Copy link
Contributor

NicolasDorier commented Jul 27, 2020

I want to merge!

@dennisreimann
Copy link
Member Author

dennisreimann commented Jul 27, 2020

I want @Kukks to have a look first, just to ensure I haven't forgotten something in the send dialogs.

@dennisreimann dennisreimann marked this pull request as ready for review Jul 27, 2020
@dennisreimann
Copy link
Member Author

dennisreimann commented Aug 3, 2020

@Kukks can you take a look and verify?

@Kukks
Copy link
Member

Kukks commented Aug 3, 2020

Just tiny nits not even related to PR but since you adjusted the same area might as well include them.

Kukks
Kukks approved these changes Aug 3, 2020
Copy link
Member

@Kukks Kukks left a comment

@NicolasDorier NicolasDorier merged commit b47b942 into btcpayserver:master Aug 3, 2020
0 of 3 checks passed
@dennisreimann dennisreimann deleted the wallet-ui branch Aug 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants