Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support LNURL Auth #3083

Merged
merged 1 commit into from
Jan 14, 2022
Merged

Support LNURL Auth #3083

merged 1 commit into from
Jan 14, 2022

Conversation

Kukks
Copy link
Member

@Kukks Kukks commented Nov 11, 2021

closes #3061

@Kukks Kukks requested a review from NicolasDorier November 15, 2021 08:21
@pavlenex
Copy link
Contributor

Concept ack but wasn't able to test it on regtest due to localhost. My wallet recognized it though.

I like how it's nested under devices since fido2 and lnurl are quite similar.

Screenshot 2021-11-15 at 21 32 54
Screenshot 2021-11-15 at 21 33 01

@Kukks weird thing is that it works without me having a store/LN/LNURL enabled as a payment method. I assume that's normal?

@Kukks Kukks added this to the 1.4.0 milestone Nov 24, 2021
@Kukks
Copy link
Member Author

Kukks commented Nov 25, 2021

Concept ack but wasn't able to test it on regtest due to localhost. My wallet recognized it though.

I like how it's nested under devices since fido2 and lnurl are quite similar.

Screenshot 2021-11-15 at 21 32 54 Screenshot 2021-11-15 at 21 33 01

@Kukks weird thing is that it works without me having a store/LN/LNURL enabled as a payment method. I assume that's normal?

Yup correct. LNURLAuth does not require you to set it up inside a store and works independently. Ironically, a non lightning wallet can implement this spec very easily (I've done so in the tests)

@Kukks Kukks force-pushed the lnurlauth branch 2 times, most recently from 65c310c to b300af6 Compare December 15, 2021 07:33
@Kukks Kukks requested a review from NicolasDorier December 20, 2021 09:07
@Kukks Kukks force-pushed the lnurlauth branch 3 times, most recently from db8dcfb to 81d45f6 Compare December 28, 2021 09:15
@NicolasDorier
Copy link
Member

doesn't build

@Kukks Kukks force-pushed the lnurlauth branch 3 times, most recently from c301968 to dca7fad Compare January 14, 2022 12:09
@Kukks Kukks merged commit 7243aec into btcpayserver:master Jan 14, 2022
@Kukks Kukks deleted the lnurlauth branch January 14, 2022 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NicolasDorier NicolasDorier Awaiting requested review from NicolasDorier

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.4.0
Development

Successfully merging this pull request may close these issues.

Add LNURL-Auth support
3 participants
@Kukks @pavlenex @NicolasDorier