Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mobile navigation #3331

Merged
merged 7 commits into from Jan 21, 2022
Merged

Conversation

dennisreimann
Copy link
Member

In #3277 there are three proposals for the mobile navigation:

As this is something to be tested and experienced, here's as first version the horizontal scrolling approach (first example).

image

Personally I think this one has some downsides:

  • Horizontal scrolling is not a widely used UX pattern
  • Items might be overlooked, because the user might not know that there are more nav links available (out of visible area)
  • After navigation the scroll position resets and the currently active item might not be visible. (This could be doable using JS though)

To prevent the second problem, I've added scroll indicators on the ends (see screenshot).

I'd prefer the second approach, though I see the downside of an added click to open the dropdown before selecting the nav item.

This version was easier to implement though, so I thought let's give it a go and try it.
Let me know your thoughts, @pavlenex @dstrukt.

Closes #3277.

@dstrukt
Copy link
Member

dstrukt commented Jan 18, 2022

Ooo I was curious myself, even if it's not feasible.

Will take a look later today!

@pavlenex
Copy link
Contributor

I mean many apps like Instagram use horizontal scrolling, I don't think it's an uncommon pattern.

@dstrukt
Copy link
Member

dstrukt commented Jan 19, 2022

Took a look on iOS Safari. Looks great!

I like the horizontal menu, would definitely like to see a variety of device sizes test this though .. the concern that the gap between tabs could obscure the fact there are more nav items is a legitimate concern.

Another thing to consider is the viewport size, do we lock it to 1, and prevent zooming?

  1. Would like the content overlay on nav open to be black, not white, in Light Mode, but that's a subtle note.

  2. Some visual display bugs, imagine this is probably consistent across the app:

IMG_7336

IMG_7337

@dennisreimann
Copy link
Member Author

Updated the overlay/backdrop color and reduced the space between the nav items on mobile.

light

dark

@pavlenex
Copy link
Contributor

LGTM would require some of us playing a bit on mobile, but on the surface I don't see any problems except one:
This should be fixed 😄
Not sure if this PR introduced it, but noticed it here.
Screenshot 2022-01-19 at 09 42 06

@dennisreimann
Copy link
Member Author

Oh yeah, thanks @pavlenex – we seem to be using the modal class wrongly there.

@pavlenex
Copy link
Contributor

@dennisreimann Seems like also in modals, delete a store and here

2022-01-19_10-14-42.mp4

@dennisreimann
Copy link
Member Author

Yup, sorry it was me rushing it. Will send a fix.

@dstrukt
Copy link
Member

dstrukt commented Jan 19, 2022

Was thinking about this last night, I'm also wondering if it might be helpful to leave the bottom border for mobile as well..? It's a little less minimal I suppose, but does make the length, etc.. quite clear.

@dennisreimann
Copy link
Member Author

I'm also wondering if it might be helpful to leave the bottom border for mobile as well..? It's a little less minimal I suppose, but does make the length, etc.. quite clear.

Yes, tried and applied it, good suggestion!

I'd say this one is good to go. As I said it is already better than what we currently have and we should ship with this one applied.

@dstrukt
Copy link
Member

dstrukt commented Jan 20, 2022

Will take a last look, but was happy with where it was, if the only additional is the bottom border .. approval incoming!

@dennisreimann dennisreimann added this to the 1.4.0 milestone Jan 20, 2022
@dennisreimann dennisreimann added Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers labels Jan 20, 2022
@NicolasDorier NicolasDorier merged commit c338846 into btcpayserver:master Jan 21, 2022
@dennisreimann dennisreimann deleted the mobile-subnav branch January 21, 2022 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Improvements to an existing feature UI / UX Front-end issues, for front-end designers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabbed Navigation Functionality for Tablet & Mobile
4 participants