New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mobile navigation #3331
Mobile navigation #3331
Conversation
Ooo I was curious myself, even if it's not feasible. Will take a look later today! |
I mean many apps like Instagram use horizontal scrolling, I don't think it's an uncommon pattern. |
Took a look on iOS Safari. Looks great! I like the horizontal menu, would definitely like to see a variety of device sizes test this though .. the concern that the gap between tabs could obscure the fact there are more nav items is a legitimate concern. Another thing to consider is the viewport size, do we lock it to 1, and prevent zooming?
|
Oh yeah, thanks @pavlenex – we seem to be using the modal class wrongly there. |
@dennisreimann Seems like also in modals, delete a store and here 2022-01-19_10-14-42.mp4 |
Yup, sorry it was me rushing it. Will send a fix. |
Was thinking about this last night, I'm also wondering if it might be helpful to leave the bottom border for mobile as well..? It's a little less minimal I suppose, but does make the length, etc.. quite clear. |
c66e166
to
6664581
Compare
Yes, tried and applied it, good suggestion! I'd say this one is good to go. As I said it is already better than what we currently have and we should ship with this one applied. |
Will take a last look, but was happy with where it was, if the only additional is the bottom border .. approval incoming! |
In #3277 there are three proposals for the mobile navigation:
As this is something to be tested and experienced, here's as first version the horizontal scrolling approach (first example).
Personally I think this one has some downsides:
To prevent the second problem, I've added scroll indicators on the ends (see screenshot).
I'd prefer the second approach, though I see the downside of an added click to open the dropdown before selecting the nav item.
This version was easier to implement though, so I thought let's give it a go and try it.
Let me know your thoughts, @pavlenex @dstrukt.
Closes #3277.