Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability to choose the themeing strategy: Extend one of the existing themes (light or dark) or go fully custom. The latter was the only option up to now, which isn't ideal:
This PR makes it so that one can choose light or dark as base theme and do modifications on top.
Benefit: You can specify a limited set of variables and might get away with 5-20 lines of CSS.
Example: This is what the CSS theme for Einundzwanzig could look like:
This is the implementation for themeing on the server/instance level — a similar and maybe even more reduced approach could be used for the stores as well. I'll tackle that once we get to unify the public store-related pages with the new checkout design.
In Action
Backwards-compatibility
The default option is "fully custom", which makes it work with the
CustomThemeCssUri
which might be specified already. If that property is set, we also don't show the CSS file upload, because those would conflict.The idea here is that we can deprecate the old way of themeing by presenting the new one in case the old approach isn't used (anymore).