-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wallet Transactions Export: Add BIP-329 support #4799
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisreimann
added
Enhancement
Improvements to an existing feature
Wallet
Related to internal BTCPay wallet
labels
Mar 21, 2023
Can I test it somewhere with another wallet? I believe you should also export the addresses. Me or @Kukks can add that to the PR after. Also it should be |
Kukks
requested changes
Mar 22, 2023
Kukks
requested changes
Mar 22, 2023
I give up implementing address export for now. |
NicolasDorier
approved these changes
Mar 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for the BIP 329 export format.
Sample transactions export:
Currently only the transaction data is exported, but I think we can also leverage the new labeling system to export other types, like
addr
as well. @NicolasDorierCloses #4536.