Do not throttle pos when logged in#6415
Merged
NicolasDorier merged 2 commits intobtcpayserver:masterfrom Dec 9, 2024
Merged
Conversation
| string formResponse = null, | ||
| CancellationToken cancellationToken = default) | ||
| { | ||
| if (!(await _authorizationService.AuthorizeAsync(HttpContext.User, appId, Policies.CanViewInvoices)).Succeeded && |
Member
There was a problem hiding this comment.
I don't believe you need to do this, you already have access to the User in the controller, which can tell you if it's anonymous or not. (IMHO if it's not anonymous it's good enough to skip the limit)
Member
Author
There was a problem hiding this comment.
It's still a vector on big public instances like voltage. Anyone can get a trial account and then be able to spam another's store trivially
Member
|
@Kukks tests are broken |
NicolasDorier
force-pushed
the
rate-limit-pos
branch
from
1206ce7 to
a21c40a
Compare
NicolasDorier
force-pushed
the
rate-limit-pos
branch
from
a21c40a to
7da247f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.