Disable cold wallet creation by default - #6626
Merged
Merged
Conversation
|
I am using the BTCPay website. I created a shop, with a connected wallet, and there was no recovery phrase at all, now I am stuck and cannot withdraw my funds. |
I'm here to help you further reach out to this s.slater82@yahoo.com |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
By default, users on a third-party BTCPay Server can create a cold wallet. However, most inexperienced users forget to back up the seed during creation, receive funds, and then become unable to access their money, eventually seeking help in our support channel. Sadly, we can't do anything for those users as the seed aren't saved by the server for cold wallets.
Even for experienced users, this feature has limited benefits. Spending requires copying and pasting the seed into another software or directly into BTCPay to sign the transaction, which results in a terrible user experience. Instead, an experienced user should generate the seed in another wallet software rather than in BTCPay Server.
Implementation
By default, non-admin users will not be able to create wallets via the UI. This setting can be changed in the server's policies.
The user will see the option disabled in the setup wizard.
While we could completely remove a step in the on-chain wallet creation wizard when both Hot Wallet and Cold Wallet creation are disabled for the user, I decided to keep it to allow for feature discovery. This way, the user can see that the option is disabled by the administrator and may choose to request access.
Admins can still create cold wallets regardless of the server policy settings.
Fix #5798