Use -b for deprecated --datadir short option. #433
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
OK |
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Dec 6, 2016
This tool is no longer necessary to force rescans with the new rescan RPCs available in both the JSON-RPC and gRPC servers, and the new versions are better anyways (can start the rescan at any block height, and for the gRPC version, the RPC returns a stream of progress notifications). For situations where problematic transation data must be removed from the wallet database, a reseed should be performed. It is better to have a single method of fixing these wallets instead of several. The wtxmgr namespace is now required to exist when opening a wallet. Older versions of the dropwtxmgr tool should not be used on the database anymore. Closes btcsuite#433.
jrick
added a commit
to jrick/btcwallet
that referenced
this pull request
Dec 6, 2016
This tool is no longer necessary to force rescans with the new rescan RPCs available in both the JSON-RPC and gRPC servers, and the new versions are better anyways (can start the rescan at any block height, and for the gRPC version, the RPC returns a stream of progress notifications). For situations where problematic transation data must be removed from the wallet database, a reseed should be performed. It is better to have a single method of fixing these wallets instead of several. The wtxmgr namespace is now required to exist when opening a wallet. Older versions of the dropwtxmgr tool should not be used on the database anymore. Closes btcsuite#433.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When 29f3172 deprecated the datadir
option, replacing it with --appdata/-A, the short --datadir option was
unintentinally changed from -b to -D. It was previously changed to -b
in fda2e14 for consistency with
btcd's --datadir short option.
This change reverts the unintentional switch back to -D.