Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce, fix, and modernize linting #171

Merged
merged 1 commit into from Feb 1, 2020
Merged

Enforce, fix, and modernize linting #171

merged 1 commit into from Feb 1, 2020

Conversation

@bakkot
Copy link
Collaborator

bakkot commented Feb 1, 2020

npm run lint existed, but was unused (and broken). This PR adds it to npm run test so it will get enforced by CI, fixes it, adds linting to typescript files, and bumps eslint.

I haven't changed any of the linting options (at least, not intentionally), though there's some options I should certainly like to add. But we can bikeshed those in another issue or PR.

bin/.eslintrc.js Outdated Show resolved Hide resolved
.eslintrc Show resolved Hide resolved
@bakkot bakkot force-pushed the fix-linting branch from 81dc0b1 to 1a58f7d Feb 1, 2020
@ljharb ljharb force-pushed the fix-linting branch from 1a58f7d to a08ef3d Feb 1, 2020
@ljharb
ljharb approved these changes Feb 1, 2020
@ljharb ljharb merged commit a08ef3d into master Feb 1, 2020
2 checks passed
2 checks passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@ljharb ljharb deleted the fix-linting branch Feb 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

2 participants
You can’t perform that action at this time.