-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
As a user, I can see report parsing progress on my dashboard #28
Conversation
2b7796e
to
a99b311
Compare
a99b311
to
3b63a98
Compare
90b5f71
to
ae2394f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few small comments 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
def index(conn, _params) do | ||
report_changeset = Report.create_changeset(%{}) | ||
def index(conn, params) do | ||
create_report = params[:create_report] || Report.create_changeset(%{}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am wondering why we need this and can we pass params directly to changeset 🤔 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is when we're re-rendering the page to display the error, we would want the Ecto.Changeset
to be rendered instead of the Report.create_changeset
🤔
Closes #15
What happened
Update the dashboard to display the user's reports
✅ Create a helper function to display the report's status
✅ Add showing individual reports
✅ Update Error handling to render our own HTML pages
✅ Upgraded dependencies
Insight
Created a mock oauth for UI tests, since
Wallaby
doesn't expose its conn.I tried creating a mock authentication controller before this, so that from a method we could call an environment variable to check which module to route to, but couldn't route it to there since I can't seem to write functions in the router. 🤔
Would be nice if we can do something like this
In the end I followed a similar implementation to Micky
For status, we're simply whether the
total search_results
that hashtml_caches
is equal to the total number ofsearch_results
in the report.Proof Of Work