As a web scraper, I can search Google and save results #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bterone
force-pushed
the
feature/webscraper-worker
branch
from
5dd8dd6
to
f66a40d
Compare
bterone
force-pushed
the
feature/webscraper-worker
branch
from
f66a40d
to
581fe3f
Compare
bterone
added
backend
bterone
force-pushed
the
feature/webscraper-worker
branch
from
2b7a300
to
6c4b4e4
Compare
andyduong1920
approved these changes
Jan 13, 2021
hanam1ni
approved these changes
Jan 14, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What happened
Working on this in #14
🚧 Create service to extract advertiser information from the response
Insight
Created a search worker using Oban. Thanks to @andyduong1920's article on choosing a background job 🕺
Using Oban we can have greater control over the job scheduling and have more resilient queues.
Currently, we're defaulting to 5 max concurrent queues every 2 seconds and retrying only twice.
Proof Of Work
Tests pass ✅
Saves HTML cache and our sample data
