Decorators not properly annotated

[danielmcormond]

I believe the current implementation for annotating AngularJS decorators might be wrong.

It looks like the current decorator test in simple.js:112 isn't realistic.

For example, if you actually used this syntax in an app:

angular.module('myMod', [])
  .decorator('myService', function (dep) {});

You would get this error:

Uncaught TypeError: Object #<Object> has no method 'decorator'

I believe a valid decorator definition looks more like this:

angular.module('myMod', [])
  .config(function($provide) {
    $provide.decorator('myService', function($delegate) {});
  });

In this case, the $delegate dependency is not being correctly annotated.

Unfortunately, I don't have time to work on a PR right now. But I at least wanted to create an issue in case others experience this and are searching. 😄

[mgcrea]

👍 same issue here

[btford]

confirmed; this was a silly error on my part.

[marcalj]

I'm not completelly sure if this issue is related in fact $provide.factory isn't ngminfied.

    .config(function ($provide, $routeProvider) {
        var resolve = {
            auth: 'authResolve'
        };

        $provide.factory('authResolve', function (AuthService) {
            return AuthService.check();
        });

becomes:

.config([
  '$provide',
  '$routeProvider',
  function ($provide, $routeProvider) {
    var resolve = {
        auth: 'authResolve',
        cache: 'cacheResolve'
      };
    $provide.factory('authResolve', function (AuthService) {
      return AuthService.check();
    });

authResolve is not parsed correctly.

[kirill-konshin]

Still does not work:

$provide.decorator("$exceptionHandler", function($delegate, $injector, $log) {

is skipped...

[steve8708]

+1 on this, would be really nice!

[mike1808]

Met this issue today
+1

[eddiemonge]

Try using ng-annotate as that will replace ng-min soon