New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add E-Prime support #71

Merged
merged 6 commits into from Mar 27, 2017

Conversation

Projects
None yet
2 participants
@Vorror
Contributor

Vorror commented Mar 22, 2017

E-Prime support for #70

I did the following things:

  • Added e-prime support
  • Made e-prime opt-in
  • Added --yes-[checkname] support to allow users to enable it
  • Modified readme
@RichardLitt

This comment has been minimized.

Show comment
Hide comment
@RichardLitt

RichardLitt Mar 22, 2017

Collaborator

Add some tests?

Collaborator

RichardLitt commented Mar 22, 2017

Add some tests?

@Vorror

This comment has been minimized.

Show comment
Hide comment
@Vorror

Vorror Mar 22, 2017

Contributor

Ah, I forgot to add some to write-good itself. I'll add tests later today!

Contributor

Vorror commented Mar 22, 2017

Ah, I forgot to add some to write-good itself. I'll add tests later today!

@Vorror

This comment has been minimized.

Show comment
Hide comment
@Vorror

Vorror Mar 22, 2017

Contributor

Done :)

Contributor

Vorror commented Mar 22, 2017

Done :)

@Vorror

This comment has been minimized.

Show comment
Hide comment
@Vorror

Vorror Mar 27, 2017

Contributor

@RichardLitt nudge ;)

Contributor

Vorror commented Mar 27, 2017

@RichardLitt nudge ;)

@RichardLitt

RichardLitt requested changes Mar 27, 2017 edited

Almost there.

How does this test for contractions? And what happens if there is a possessive? Mary's sheep's dead. didn't flag an issue.

Show outdated Hide outdated write-good.js Outdated
@Vorror

This comment has been minimized.

Show comment
Hide comment
@Vorror

Vorror Mar 27, 2017

Contributor

@RichardLitt Sure I'll make that change and use the module. In regards to the check, they're all listed here.

In regards to checking possessive vs contractions. I'm not sure if "sheep's" is a valid contraction of "sheep is", although I very well could be wrong.

Contributor

Vorror commented Mar 27, 2017

@RichardLitt Sure I'll make that change and use the module. In regards to the check, they're all listed here.

In regards to checking possessive vs contractions. I'm not sure if "sheep's" is a valid contraction of "sheep is", although I very well could be wrong.

@RichardLitt RichardLitt merged commit 9b65ac5 into btford:master Mar 27, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@RichardLitt

This comment has been minimized.

Show comment
Hide comment
@RichardLitt

RichardLitt Mar 27, 2017

Collaborator

Well done! Thank you.

Collaborator

RichardLitt commented Mar 27, 2017

Well done! Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment