Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes scratch_dir not found error #55

Merged
merged 2 commits into from Oct 30, 2013

Conversation

Projects
None yet
2 participants
@reijop
Copy link
Contributor

commented Oct 28, 2013

Found a scratch_dir not found error on 10.28. Turns the variable into a node attribute.

@dpetzel

This comment has been minimized.

Copy link
Collaborator

commented Oct 28, 2013

Ha, I was just trying to get setup with chef-zero to try and reproduce this. I don't think scratch dir needs to be a node attribute. It exists only as workaround to force downloading of files from the server, and it shouldn't ideally hold any prominent position in the cookbook.

The fix I was thinking about was to update def load_tests(scratch_dir) and then load_tests(scratch_dir), or do you think there is value in exposing scratch_dir?

@reijop

This comment has been minimized.

Copy link
Contributor Author

commented Oct 28, 2013

Hey Dave! I was thinking in a pretty primitive fashion when I came up with this.

I like yours better.

I really would only care about any reports that come out of minitest - I can't see a situation for another CB/handler to know about scratch_dir.

@dpetzel

This comment has been minimized.

Copy link
Collaborator

commented Oct 28, 2013

You wanna amend this PR with another commit if you're already setup to test?

@dpetzel

This comment has been minimized.

Copy link
Collaborator

commented Oct 30, 2013

I'm having a heck of a time getting my workstation configured properly with chef-zero to test this code path (its not hit with chef-solo). That said this looks just like what I was thinking, so I am going accept this and get a release cut.

dpetzel added a commit that referenced this pull request Oct 30, 2013

Merge pull request #55 from reijop/master
fixes scratch_dir not found error

@dpetzel dpetzel merged commit 737f44b into btm:master Oct 30, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.