Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Accept invalid .torrent files. #36

Merged
merged 1 commit into from May 6, 2012

Conversation

Projects
None yet
1 participant
@ghost

ghost commented Apr 3, 2012

Accept .torrent files whose bencoded dictionaries are not in
alphabetical order.

As originally explained on the btpd Google group:

I have an improperly-formatted .torrent file; specifically, the
"announce" key comes last in the top-level dictionary -- if it were
properly formatted, it would come first. (In a bencoded dictionary,
the keys are supposed to be in alphabetical order.) When I try to add
this torrent using bcli, I get an error:
error loading '[path]' (Invalid argument).
Clearly, the problem here is the badly-formatted .torrent file, but
other clients handle it fine, and the .torrent file does contain all
of the information that the daemon needs. If it were me, I would have
btpd accept this kind of bad input, but different projects have
different policies.

I am re-posting this pull request because I deleted my original account. The original is here: #30. If this patch is accepted, please approve this pull request and delete the old one.

Accept invalid .torrent files.
Accept .torrent files whose bencoded dictionaries are not in
alphabetical order.

@ghost ghost assigned queueRAM Apr 26, 2012

queueRAM added a commit that referenced this pull request May 6, 2012

Merge pull request #36 from brianmwaters/master
Accept bencoded dictionaries whose keys are not in alphabetical order.

Closes GH-30
Closes GH-36

@queueRAM queueRAM merged commit c408419 into btpd:master May 6, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment