New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support JDK 1.7+ on OS X #128

Merged
merged 2 commits into from Jun 24, 2015

Conversation

Projects
None yet
2 participants
@oschrenk
Contributor

oschrenk commented Jun 15, 2015

JDK versions starting with 1.7 are installed to

/Library/Java/JavaVirtualMachines/<version>/Contents/Home

oschrenk added some commits Jun 14, 2015

Support JDK 1.7+ on OS X
Since 1.7 installation directory of the JDK has changed and is now
installed under

/Library/Java/JavaVirtualMachines/${JAVA_VERSION}/Contents/Home

and tools.jar is in ${JAVA_HOME}/lib/tools.jar
@jbachorik

This comment has been minimized.

Show comment
Hide comment
@jbachorik

jbachorik Jun 16, 2015

Collaborator

Hi Oliver,

thanks for the fix. But you will need to sign the Oracle Contributor Agreement before I am able to accept this pull request. Sorry for the inconvenience.

-JB-

Collaborator

jbachorik commented Jun 16, 2015

Hi Oliver,

thanks for the fix. But you will need to sign the Oracle Contributor Agreement before I am able to accept this pull request. Sorry for the inconvenience.

-JB-

@oschrenk

This comment has been minimized.

Show comment
Hide comment
@oschrenk

oschrenk Jun 16, 2015

Contributor

Working on it. Just wanted to send the pull request to get some feedback.

It would be nice if the page would actually explain the steps you have to do. I have to go to the FAQ to actually figure it out on my own.

Edit: Well they could make it easier. You easily miss the oracle- prefix of the email (they even forgot it themselves linking to the wrong mail address in their FAQ pdf)

Contributor

oschrenk commented Jun 16, 2015

Working on it. Just wanted to send the pull request to get some feedback.

It would be nice if the page would actually explain the steps you have to do. I have to go to the FAQ to actually figure it out on my own.

Edit: Well they could make it easier. You easily miss the oracle- prefix of the email (they even forgot it themselves linking to the wrong mail address in their FAQ pdf)

@oschrenk

This comment has been minimized.

Show comment
Hide comment
@oschrenk

oschrenk Jun 16, 2015

Contributor

Mail sent.

Contributor

oschrenk commented Jun 16, 2015

Mail sent.

@jbachorik jbachorik added this to the 1.3.1 milestone Jun 16, 2015

jbachorik added a commit that referenced this pull request Jun 24, 2015

@jbachorik jbachorik merged commit 328fd61 into btraceio:master Jun 24, 2015

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@jbachorik

This comment has been minimized.

Show comment
Hide comment
@jbachorik

jbachorik Jun 24, 2015

Collaborator

OCA has been successfully processed :) Congrats!

Collaborator

jbachorik commented Jun 24, 2015

OCA has been successfully processed :) Congrats!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment