This repository has been archived by the owner on Jan 7, 2019. It is now read-only.
Fastboot, destructuring, and ESLint #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| destroyApp(this.application); | ||
| let afterEach = options.afterEach && options.afterEach.apply(this, arguments); | ||
| return Promise.resolve(afterEach).then(() => destroyApp(this.application)); |
There was a problem hiding this comment.
why are changes to this file necessary?
There was a problem hiding this comment.
Ember CLI changed this file. I ran ember init and pulled in all the necessary changes.
|
@bttf any issues with this PR? |
|
@rwwagner90 it appears that this breaks with apps that do not have fastboot already installed |
|
@bttf okay, I can fix that. |
|
@bttf should be fixed now. Please give it a look |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I updated to ember-cli 2.7.0, switched from jshint to ESLint, destructured Ember, and added checks for fastboot.
Resolves #4