Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slider tooltip #128

Merged
merged 8 commits into from Oct 27, 2019

Conversation

@ThomasLuu00
Copy link
Contributor

ThomasLuu00 commented Oct 23, 2019

PR Checklist

Please check all that apply to this PR using "x":

  • I have checked that this PR is not a duplicate of an existing PR (open, closed or merged)
  • I have checked that this PR does not introduce a breaking change
  • This PR introduces breaking changes and I have provided a detailed explanation below

PR Type

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update (formatting)
  • Refactoring (no functional changes)
  • Documentation changes
  • Other - Please describe:

Fixes

Issue Number: #119

What is the current behavior?

There's no tooltip indicating the value of the slider.

What is the new behavior?

There's a tooltip now.

Other information

ThomasLuu00 added 3 commits Oct 23, 2019
@btzr-io

This comment has been minimized.

Copy link
Owner

btzr-io commented Oct 23, 2019

can you post a screen preview or a gif / video ?

@ThomasLuu00

This comment has been minimized.

Copy link
Contributor Author

ThomasLuu00 commented Oct 23, 2019

example

src/components/slider/handle.js Outdated Show resolved Hide resolved
src/components/slider/handle.js Outdated Show resolved Hide resolved
src/components/slider/tooltipRail.js Outdated Show resolved Hide resolved
src/components/slider/tooltipRail.js Outdated Show resolved Hide resolved
src/components/slider/tooltipRail.js Outdated Show resolved Hide resolved
src/components/slider/index.js Outdated Show resolved Hide resolved
@btzr-io btzr-io changed the title Issue119 Slider tooltip Oct 24, 2019
ThomasLuu00 added 3 commits Oct 26, 2019
Renamed TooltipRail to SliderRail
Removed Fragments
Placed Tooltips within corresponding objects
Moved tooltip.css into styles.css
Copy link

accesslint bot left a comment

There are accessibility issues in these changes.

examples/demo.js Show resolved Hide resolved
examples/demo.js Show resolved Hide resolved
examples/demo.js Show resolved Hide resolved
@ThomasLuu00

This comment has been minimized.

Copy link
Contributor Author

ThomasLuu00 commented Oct 27, 2019

@btzr-io I have finished doing the changes and dealt with the conflicts.

@btzr-io btzr-io merged commit 3037e8f into btzr-io:master Oct 27, 2019
1 check passed
1 check passed
AccessLint Found 3 issues
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.