New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promise rejection handler warning #47

Closed
lholmquist opened this Issue Nov 1, 2016 · 2 comments

Comments

Projects
None yet
2 participants
@lholmquist
Member

lholmquist commented Nov 1, 2016

While running in Node 7, There is a test that produces the

(node:80749) UnhandledPromiseRejectionWarning: Unhandled promise rejection (rejection id: 1): package.json is require

(node:80749) DeprecationWarning: Unhandled promise rejections are deprecated. In the future, promise rejections that are not handled will terminate the Node.js process with a non-zero exit code.`

we should probably fix that. Not sure if it is the test or the lib that is the issue

@lholmquist lholmquist added this to the 0.7.0 milestone Nov 1, 2016

@lholmquist lholmquist self-assigned this Nov 1, 2016

lholmquist added a commit to lholmquist/szero that referenced this issue Nov 1, 2016

@lholmquist

This comment has been minimized.

Show comment
Hide comment
@lholmquist

lholmquist Nov 1, 2016

Member

now here: dbe60f8

Member

lholmquist commented Nov 1, 2016

now here: dbe60f8

@lholmquist lholmquist closed this Nov 1, 2016

@tiagofabre

This comment has been minimized.

Show comment
Hide comment
@tiagofabre

tiagofabre Apr 5, 2017

Contributor

Why is this closed? To change the input will only hide the warning, but the problem stills there.

To solve this issue we need to handle the rejection of promise just like that:

run(program.args[0], options).catch(error) { throw error };

Contributor

tiagofabre commented Apr 5, 2017

Why is this closed? To change the input will only hide the warning, but the problem stills there.

To solve this issue we need to handle the rejection of promise just like that:

run(program.args[0], options).catch(error) { throw error };

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment