Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes calculation of historical prices when applying split #2522

Merged
merged 3 commits into from Nov 16, 2021

Conversation

OnkelDok
Copy link
Member

@OnkelDok OnkelDok commented Nov 12, 2021

@OnkelDok
Copy link
Member Author

OnkelDok commented Nov 12, 2021

I have the feeling this PR is not related to the issue (Jan 2020) linked in my commit ef5c9a3.
Because the bug came in with 54b29dd (Oct 2021).

Is it possible to change the commit message to remove the "fixes ..."?

@OnkelDok OnkelDok changed the title fixes calculation of historical prices when applying split, fixes #1368 fixes calculation of historical prices when applying split Nov 12, 2021
@buchen buchen merged commit 57f718e into portfolio-performance:master Nov 16, 2021
@buchen
Copy link
Member

buchen commented Nov 16, 2021

Thanks @OnkelDok

Yes, I added the bug when allowing split ratios with decimal places :sad:

I have removed the link to the wrong bug

@OnkelDok OnkelDok deleted the split_bug branch November 17, 2021 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants