Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend time grid of StackedTimelineChart #2954

Closed

Conversation

OnkelDok
Copy link
Member

The time grid of the taxonomy area chart is different to other ones (e.g. in statement of assets historical chart). In the current version there is only a vertical line for each year. Additionally the color of the vertical line and the text has a color which is difficult to see. Reported here: https://forum.portfolio-performance.info/t/beschriftung-der-zeitachse-im-flachendiagramm-der-klassifizierung-fehlt/21607

So I changed the color and used the same time grid calculation in the StackedTimelineChart as in the TimelineChart.
Here some screenshots from current version and same view with this PR:

Period 3 years
Current Version:
grafik
With this PR:
grafik

Period 100 days
Current Version:
grafik
With this PR:
grafik

@buchen
Copy link
Member

buchen commented Aug 22, 2022

Hi @OnkelDok,

thanks for the contribution. I have added one more commit which is refactoring the painting of the time grid into a separate helper class. That reduces somewhat the code and ensures the behavior is identical (for example to not label lines if there is not enough space).

@buchen buchen closed this Aug 22, 2022
@OnkelDok OnkelDok deleted the extend_time_grid branch August 23, 2022 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants