New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a pre-installation redirection to /admin #84

Merged
merged 1 commit into from May 24, 2015

Conversation

Projects
None yet
2 participants
@ChristianGaertner
Contributor

ChristianGaertner commented Mar 14, 2015

Instead of a 404 error Buckets will now redirect
the user to the admin dashboard on initial launch.

This approach uses the routes array to determine,
whether the app is in a pre-install state.

Performance wise does this commit change nothing, since
the if check has just been moved to another location.

A 302 'Found' code is sent along with the redirect (none permanent).

(See my comment on the bounty on Assembly for a brief explanation why I choose this approach)

Cheers,

Christian

Added a pre-installation redirection to /admin
Instead of a 404 error Buckets will now redirect
the user to the admin dashboard on initial launch.

This approach uses the routes array to determine,
whether the app is in a pre-install state.

Performance wise does this commit change nothing, since
the if check has just been moved to another location.

A 302 'Found' code is sent along with the redirect (none permanent).
@ChristianGaertner

This comment has been minimized.

Show comment
Hide comment
@ChristianGaertner

ChristianGaertner Mar 15, 2015

Contributor

I've just double checked and cannot reproduce the build error in my local enviroment. Can any one confirm the build error?

Contributor

ChristianGaertner commented Mar 15, 2015

I've just double checked and cannot reproduce the build error in my local enviroment. Can any one confirm the build error?

@ChristianGaertner

This comment has been minimized.

Show comment
Hide comment
@ChristianGaertner

ChristianGaertner May 23, 2015

Contributor

Is there any interest at all, or should I just close the PR?

Any kind of feedback would awesome!

Contributor

ChristianGaertner commented May 23, 2015

Is there any interest at all, or should I just close the PR?

Any kind of feedback would awesome!

@davidkaneda

This comment has been minimized.

Show comment
Hide comment
@davidkaneda

davidkaneda May 24, 2015

Contributor

Very sorry for the delay, this looks great!

Contributor

davidkaneda commented May 24, 2015

Very sorry for the delay, this looks great!

davidkaneda added a commit that referenced this pull request May 24, 2015

Merge pull request #84 from ChristianGaertner/bounty-261
Added a pre-installation redirection to /admin

@davidkaneda davidkaneda merged commit 1b18ffe into bucketsio:master May 24, 2015

1 check failed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment