Join GitHub today
GitHub is home to over 28 million developers working together to host and review code, manage projects, and build software together.
Sign uplibtiff denying saving of really large images #148
Comments
zebastian
added
the
BUG
label
Nov 1, 2016
zebastian
self-assigned this
Nov 1, 2016
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
buddhi1980
Nov 1, 2016
Owner
Here is the answer: http://www.awaresystems.be/imaging/tiff/faq.html#q8
The format uses 32bit offsets, and as such, it is limited to 4 gigabytes. Many implementations handle these offsets using signed integers, and thus support files of up to 2 gigabytes, but the only real limit resulting from the format specification is 4 gigabytes.
|
Here is the answer: http://www.awaresystems.be/imaging/tiff/faq.html#q8 The format uses 32bit offsets, and as such, it is limited to 4 gigabytes. Many implementations handle these offsets using signed integers, and thus support files of up to 2 gigabytes, but the only real limit resulting from the format specification is 4 gigabytes. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
Fixed by commit cfe4ed0 I'm going to release 2.09-3 with this bugfix |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mclarekin
Nov 1, 2016
Collaborator
can you include this replacement text with V2.09.3
transformCommon.benesiT1EnabledFalse = container->Get("transf_
benesi_T1_enabled_false");
transformCommon.benesiT1MEnabledFalse = container->Get("transf_
benesi_T1M_enabled_false");
I had them switched
On Wed, Nov 2, 2016 at 9:43 AM, Krzysztof Marczak notifications@github.com
wrote:
Fixed by commit cfe4ed0
cfe4ed0I'm going to release 2.09-3 with this bugfix
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#148 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMLZHNqqq1cNtBKw94Usb-5TQIZIEIx-ks5q56R1gaJpZM4KmZ_y
.
|
can you include this replacement text with V2.09.3 transformCommon.benesiT1EnabledFalse = container->Get("transf_ I had them switched On Wed, Nov 2, 2016 at 9:43 AM, Krzysztof Marczak notifications@github.com
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
|
@mclarekin , I can add this change to 2.09-3 |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
buddhi1980
Nov 2, 2016
Owner
@mclarekin , I'm not sure what I should change here. In 2.09-2 transformCommon.benesiT1MEnabledFalse didn't exist.
You have added TransformScaleVaryVCLIteration() formula just 7 days ago, so it's not included in 2.09 at all.
Here is your change: 38e14a9#diff-048e74ab08be3a31d1abc425824bb60d
|
@mclarekin , I'm not sure what I should change here. In 2.09-2 transformCommon.benesiT1MEnabledFalse didn't exist. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
mclarekin
Nov 2, 2016
Collaborator
my mistake, I thought I had made the change before V2.09 release, but I
now see it was done after. :)
On Thu, Nov 3, 2016 at 6:20 AM, Krzysztof Marczak notifications@github.com
wrote:
@mclarekin https://github.com/mclarekin , I'm not sure what I should
change here. In 2.09-2 transformCommon.benesiT1MEnabledFalse didn't
exist.
You have added TransformScaleVaryVCLIteration() formula just 7 days ago,
so it's not included in 2.09 at all.
Here is your change: 38e14a9#diff-048e74ab08be3a31d1abc425824bb60d
38e14a9#diff-048e74ab08be3a31d1abc425824bb60d—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#148 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AMLZHEn6OfnuE3YTpRkDuetvXw7PiGdcks5q6MZpgaJpZM4KmZ_y
.
|
my mistake, I thought I had made the change before V2.09 release, but I On Thu, Nov 3, 2016 at 6:20 AM, Krzysztof Marczak notifications@github.com
|
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
buddhi1980
Nov 3, 2016
Owner
I had one surprise here. When program was compiled with mingw32, then 'long int' type was only 32-bit size (PNG and TIFF failed under Windows10).
There is always needed to use int64_t or uint64_t to be sure that variable will have 64-bit size.
Latest commit solved this problem (63a14a6)
The program was tested under Win10 and everything seams to work properly (tested image of resolution 16000x28000)
Tomorrow I'm going to publish new packages.
|
I had one surprise here. When program was compiled with mingw32, then 'long int' type was only 32-bit size (PNG and TIFF failed under Windows10). |
zebastian commentedNov 1, 2016
see also problem reported here by smurfboard: http://www.fractalforums.com/bug-reporting-b231/2-09-2-'zlib-cannot-deal-with-buffers/
program is crashing when trying to write 16bit tiff files, message: "zlib cannot deal with buffers this size" , image size is 16000x28000 pixels, i have 32gb memory.
Maybe tiff saving can be leveraged in memory consumption or saving can be "streamed" instead of total allocation.