/mandelbulber2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

netrender - connect clients while rendering #90

Closed
zebastian opened this Issue Mar 28, 2016 · 4 comments

Comments

Assignees
No one assigned
Labels
Projects
None yet
Milestone
No milestone
2 participants
@zebastian @buddhi1980
@zebastian
Collaborator

zebastian commented Mar 28, 2016

when the server already started and a new client connects to the render it does not join the rendering.
Only when a new image is rendered the client receives the job from the server and joins in.

@buddhi1980 buddhi1980 added the ENHANCEMENT label Mar 28, 2016

zebastian added a commit that referenced this issue Mar 28, 2016

@zebastian
netrender - connect clients while rendering 
this should fix issue #90
first tests seem to be fine.

The is no SendJob function anymore, but SetJob.
This behaves as before and sends the job to all connected clients, but
also stores the job in netrender persistent var 'msgCurrentJob'
when a new client connects successfully and msgCurrentJob is set, this
gets send to the new client.

@buddhi please double check the code in netrender.cpp
766c740
@buddhi1980

This comment has been minimized.

Show comment
Hide comment
@buddhi1980

buddhi1980 Mar 28, 2016

Owner

I have just tested it. It works very well. I haven't thought that it would be so easy to implement it. It is very good idea to remember message for JOB.
Owner

buddhi1980 commented Mar 28, 2016

I have just tested it. It works very well. I haven't thought that it would be so easy to implement it. It is very good idea to remember message for JOB.
@zebastian

This comment has been minimized.

Show comment
Hide comment
@zebastian

zebastian Mar 29, 2016

Collaborator

me, too. i had in mind that we already tried to implement this and that the hassle was so big that we abandoned the idea.
but this time it worked just like that. glad we got this from the list.
for the next release we should also check netrender, but i dont expect that much side effects.
Collaborator

zebastian commented Mar 29, 2016

me, too. i had in mind that we already tried to implement this and that the hassle was so big that we abandoned the idea.
but this time it worked just like that. glad we got this from the list.
for the next release we should also check netrender, but i dont expect that much side effects.

@zebastian zebastian closed this Mar 29, 2016

@buddhi1980

This comment has been minimized.

Show comment
Hide comment
@buddhi1980

buddhi1980 Mar 29, 2016

Owner

Now I'm rendering animation using NetRender so it will be intensively tested.
Owner

buddhi1980 commented Mar 29, 2016

Now I'm rendering animation using NetRender so it will be intensively tested.
@zebastian

This comment has been minimized.

Show comment
Hide comment
@zebastian

zebastian Apr 1, 2016

Collaborator

Cool, drop me a link when animation is ready
Collaborator

zebastian commented Apr 1, 2016

Cool, drop me a link when animation is ready
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment