Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup base plugin loader #1

Closed
modemlooper opened this issue Jan 13, 2016 · 7 comments

Comments

Projects
None yet
5 participants
@modemlooper
Copy link
Contributor

commented Jan 13, 2016

This could be merged should prolly structure based on current BP core plugin.

buddypress/bp-activity/bp-activity-rest.php

or

buddypress/bp-activity/bp-rest/bp-activity-endpoints.php
@slaFFik

This comment has been minimized.

Copy link
Member

commented Jan 14, 2016

+1 for buddypress/bp-activity/bp-activity-rest.php

@modemlooper

This comment has been minimized.

Copy link
Contributor Author

commented Jan 19, 2016

set up here in this fork https://github.com/modemlooper/BP-REST, I was looking though the bp plugin and the rss feed class is in bp-acitivty/classes so I thought that might be a good location for file

@Mamaduka

This comment has been minimized.

Copy link

commented Jan 25, 2016

@modemlooper I like structure in your fork. Also think that we don't need class-bp-rest-loader.php and base singleton class. We should simply initialize class in main plugin file, similar to WP REST API plugin.

Probably you should also get rid of front-end assets manager files and assets dir.

It will be nice to get this merged/closed, so we can kick-off on Schema and unit tests for read-only endpoints.

@modemlooper

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2016

the loader is only for this plugin that file will not be in core

@BronsonQuick

This comment has been minimized.

Copy link

commented Jan 27, 2016

@modemlooper Great work so far! I'm +1 on buddypress/bp-activity/bp-activity-rest.php for the folder structure.

I also agree regarding not needing a singleton and stripping out the frontend assets folder. Ryan McCue recommended the following https://github.com/BronsonQuick/BP-API/blob/master/bp-rest-api.php to me.

modemlooper added a commit that referenced this issue Jan 27, 2016

Merge pull request #1 from buddypress/master
merge from  buddypress/rest
@modemlooper

This comment has been minimized.

Copy link
Contributor Author

commented Jan 27, 2016

strip away! the assets are from WDS plugin generator.

@modemlooper modemlooper self-assigned this Jan 27, 2016

BronsonQuick pushed a commit that referenced this issue Jan 28, 2016

paulgibbs pushed a commit that referenced this issue Apr 26, 2016

Merge pull request #1 from buddypress/master
merge from  buddypress/rest

paulgibbs pushed a commit that referenced this issue Apr 26, 2016

@paulgibbs

This comment has been minimized.

Copy link
Member

commented Apr 26, 2016

This looks like it's sort-of been done since the ticket was made, so I'll close it down.

@paulgibbs paulgibbs closed this Apr 26, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.