Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Friends Endpoints #242

Merged
merged 7 commits into from Oct 14, 2019

Conversation

@renatonascalves
Copy link
Member

renatonascalves commented Oct 9, 2019

closes #149

@renatonascalves renatonascalves self-assigned this Oct 9, 2019
Copy link
Contributor

imath left a comment

Thanks for your work on this @renatonascalves Is it a first pass ?

As I've written in one of my comments, it looks like some methods are missing. Moreover I guess we have to handle some friends action a bit like we did for Group invites/Membership requets:

  • friends_accept_friendship() would be inside the update_item() method
  • friends_reject_friendship() and friends_withdraw_friendship() would be inside the delete_item() depending on the user performing the removal
@renatonascalves

This comment has been minimized.

Copy link
Member Author

renatonascalves commented Oct 9, 2019

@imath Pushed just for visibility. I'm aware of the other endpoints/methods. I'm working on that. :)

@imath

This comment has been minimized.

Copy link
Contributor

imath commented Oct 10, 2019

Awesome, well then I'd say if you want to commit a first pass, I'd suggest to remove the delete_item() method or to add the corresponding route :)

@renatonascalves

This comment has been minimized.

Copy link
Member Author

renatonascalves commented Oct 12, 2019

@imath Now I think I'm done with the endpoints.

Could you take another look?

@renatonascalves renatonascalves requested a review from imath Oct 12, 2019
@imath
imath approved these changes Oct 14, 2019
Copy link
Contributor

imath left a comment

Looks good to me! Thanks a lot for your work 👍👏

@renatonascalves renatonascalves merged commit 4c75051 into master Oct 14, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@renatonascalves renatonascalves deleted the friends branch Oct 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.