Make sure BP Activity Akismet History is an array before sorting it #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imath
changed the title
dcavins
pushed a commit
to dcavins/buddypress-wp-svn
that referenced
this pull request
Jul 28, 2023
When the Akismet plugin is active and is used to prevent BP Activity spams, each Activity item gets an Akismet history. This history is only generated for activities being posted once Akismet is on. As a result, there can be old activities with no history. To avoid potential PHP errors/notices, we need to verify the Activity Meta used to store the history is an array and has a `time` key. As we are dealing with the latest history entry only, we do not need to sort the Activity Meta. To display the activity history into its single WP Admin screen, we now need to use the `time` & `message` keys of the Activity Meta. Props mystichrome See #8873 (trunk) Closes buddypress/buddypress#93 git-svn-id: http://buddypress.svn.wordpress.org/trunk@13466 cdf35c40-ae34-48e0-9cc9-0c9da1808c22
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Into
BP_Akismet->get_activity_history()method, make sure the Activity meta used to store the Akismet history is an array before sorting with an Akismet comparison function.Trac ticket: https://buddypress.trac.wordpress.org/ticket/8873
This Pull Request is for code review only. Please keep all other discussion in the BuddyPress Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the WordPress Core Handbook for more details.