Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove placeholders from search input fields and textareas #130

Closed
mercime opened this issue Apr 18, 2017 · 2 comments

Comments

2 participants
@mercime
Copy link
Member

commented Apr 18, 2017

Continuing with the a11y improvements to search forms (#117, #129) and to textareas (#114), I've set up demos at https://codepen.io/mercime/pen/pPjWJm so we get the items done already.

<label etc.>Search Groups … </label>
<input placeholder="Search Groups …" etc.>
<button etc.>
	<span etc.></span>
	<span etc.>Search Groups …</span>
</button>

"Search Groups …" is heard 3 times for one search form so I removed placehoder="Search Groups …" and reworded the button text to just "Search" in demos.

mercime added a commit that referenced this issue May 17, 2017

mercime added a commit that referenced this issue May 17, 2017

@mercime mercime added this to In Progress in A11y Testing & Standards May 17, 2017

mercime added a commit that referenced this issue May 18, 2017

@hnla hnla moved this from In Progress to Ticket In Progress in A11y Testing & Standards Jun 6, 2017

hnla added a commit that referenced this issue Aug 25, 2017

Group invites textarea labels
Commit adds a label for invites textarea, previously omitted, adds a class `class="bp-faux-placeholder-label"` for possible future support js driven placeholder affect.

This technically reverts the revert from the initial correction/addition of label.

See #130 & #114
@hnla

This comment has been minimized.

Copy link
Member

commented Aug 25, 2017

Closing this on revertion of the revert of f6419e4 with the above commit.

@hnla hnla closed this Aug 25, 2017

@hnla hnla moved this from Ticket In Progress to Completed in A11y Testing & Standards Aug 25, 2017

@hnla hnla reopened this Sep 5, 2017

hnla added a commit that referenced this issue Sep 5, 2017

Bring group create steps invites search form html into line with dir …
…search html block.

N.B Placeholders still persist and ought to be removed as per #130
@hnla

This comment has been minimized.

Copy link
Member

commented Nov 14, 2017

Any further actions in this context will happen in core, on Trac... closing.

@hnla hnla closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.