New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blockers for core merge #194

Closed
paulgibbs opened this Issue Jul 26, 2017 · 3 comments

Comments

Projects
None yet
2 participants
@paulgibbs
Member

paulgibbs commented Jul 26, 2017

  • All the TODOs need attention and resolution.
  • Someone needs to review all the superglobals and JSON handlers and nonces, for security.
  • No more new features or theme changes. I see new stuff going in this last week, and there's ~45 outstanding tickets. Draw a line.
  • Review all i18n strings.
  • Something needs to happen with the at-since values. I am tempted to suggest we change them all to 3.0, only because I don't want to manually differentiate between the existing action/filter names and the new Nouveau functions. That'd take half a day, easy.
  • There's a lot of custom SQL. I really hope this isn't needed, but it needs review.
@paulgibbs

This comment has been minimized.

Show comment
Hide comment
@paulgibbs

paulgibbs Jul 26, 2017

Member

To re-iterate the third point, the 45 tickets open is bugging me. There simply should not be so many tickets open if the goal initially was to aim for BP 2.9.

I want to talk to @hnla about declaring Nouveau feature complete so we can close up these tickets.

Member

paulgibbs commented Jul 26, 2017

To re-iterate the third point, the 45 tickets open is bugging me. There simply should not be so many tickets open if the goal initially was to aim for BP 2.9.

I want to talk to @hnla about declaring Nouveau feature complete so we can close up these tickets.

@hnla

This comment has been minimized.

Show comment
Hide comment
@hnla

hnla Jul 26, 2017

Member

Yep Feature Complete ought to be declared as we or I can't continue adding to Nouveau at this late stage and given my exhaustion ;)

In reference to last weeks function addition if that is a reference to the customizer tab choices this was a partly implemented navigation styles that if left partial made for confusion and user inability to change where they could with other nav styles, it was a reluctant but necessary addition.

As for styles those will need to be tweaked & checks and adjustments ongoing likely still required for vendor apps.

As of now Nouveau should be considered as Feature Frozen!

Member

hnla commented Jul 26, 2017

Yep Feature Complete ought to be declared as we or I can't continue adding to Nouveau at this late stage and given my exhaustion ;)

In reference to last weeks function addition if that is a reference to the customizer tab choices this was a partly implemented navigation styles that if left partial made for confusion and user inability to change where they could with other nav styles, it was a reluctant but necessary addition.

As for styles those will need to be tweaked & checks and adjustments ongoing likely still required for vendor apps.

As of now Nouveau should be considered as Feature Frozen!

@hnla

This comment has been minimized.

Show comment
Hide comment
@hnla

hnla Nov 14, 2017

Member

As we're merged to core... closing. Items on the list still probably need scrutiny though.

Member

hnla commented Nov 14, 2017

As we're merged to core... closing. Items on the list still probably need scrutiny though.

@hnla hnla closed this Nov 14, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment