Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Colors have changed between 0.6.6 and 0.6.7 #980

Closed
rhymes opened this issue Sep 7, 2018 · 5 comments
Closed

Colors have changed between 0.6.6 and 0.6.7 #980

rhymes opened this issue Sep 7, 2018 · 5 comments

Comments

@rhymes
Copy link

rhymes commented Sep 7, 2018

The default color scheme changed between 0.6.6 and 0.6.7.

I've installed 0.6.7, refreshed the app and most icons, bars and link colors have changed

Overview of the problem

Buefy version: [0.6.7]
Vuejs version: [2.5.17]
OS/Browser: Firefox 62, Chrome

Description

The default color scheme changed from 0.6.6 to 0.6.7.

Bulma's version is still the same:

-buefy@0.6.6:
-  version "0.6.6"
-  resolved "https://registry.yarnpkg.com/buefy/-/buefy-0.6.6.tgz#e59df5258ad254498b888cd612bb1a4cc8773d0a"
+buefy@0.6.7:
+  version "0.6.7"
+  resolved "https://registry.yarnpkg.com/buefy/-/buefy-0.6.7.tgz#739045a3e2437c3abe0a3bcf3694da45f12ee24e"
   dependencies:
-    bulma "^0.7.1"
+    bulma "0.7.1"

-bulma@^0.7.1:
+bulma@0.7.1:
   version "0.7.1"
   resolved "https://registry.yarnpkg.com/bulma/-/bulma-0.7.1.tgz#73c2e3b2930c90cc272029cbd19918b493fca486"

Steps to reproduce

  • install Buefy 0.6.7
  • change import 'buefy/lib/buefy.css' to import 'buefy/dist/buefy.css'
  • restart the app

Expected behavior

This is what the various colors looked like with 0.6.6:

clipboard066

download066

search066

Actual behavior

This is how they look like as soon as I upgrade to 0.6.7:

clipboard067

download067

search067

@davedoesdev
Copy link

It seems dist/buefy.css is using the bulma primary colour (turquoise, #00d1b2).
However, src/scss/utils/_variables.scss is still setting it to purple, #7957d5

@davedoesdev
Copy link

I ran npm build:lib and the generated dist/buefy.css had the correct primary color (purple, #7957d5).

Looks like something went wrong when publishing the npm package.

@davedoesdev
Copy link

davedoesdev commented Sep 14, 2018

Looks like 64aea4c fixed it so should be fixed in next version :)

@rhymes
Copy link
Author

rhymes commented Sep 14, 2018

Thank you @davedoesdev !

@jtommy
Copy link
Member

jtommy commented Oct 12, 2018

Fix 0.7.0

@jtommy jtommy closed this as completed Oct 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants