Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring bundle build and add single components build #826

Merged
merged 37 commits into from Aug 8, 2018
Merged

Refactoring bundle build and add single components build #826

merged 37 commits into from Aug 8, 2018

Conversation

jtommy
Copy link
Member

@jtommy jtommy commented May 22, 2018

No description provided.

@codecov
Copy link

codecov bot commented May 22, 2018

Codecov Report

Merging #826 into dev will increase coverage by 0.47%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #826      +/-   ##
==========================================
+ Coverage   32.88%   33.35%   +0.47%     
==========================================
  Files          43       42       -1     
  Lines        1268     1265       -3     
  Branches      390      388       -2     
==========================================
+ Hits          417      422       +5     
+ Misses        830      824       -6     
+ Partials       21       19       -2
Impacted Files Coverage Δ
src/utils/MessageMixin.js 27.27% <ø> (ø) ⬆️
src/components/panel/Panel.vue 22.22% <100%> (+9.72%) ⬆️
src/components/taginput/Taginput.vue 26.98% <100%> (+1.17%) ⬆️
src/components/timepicker/Timepicker.vue 27.27% <100%> (+0.39%) ⬆️
src/components/datepicker/Datepicker.vue 36.47% <100%> (+0.75%) ⬆️
src/components/input/Input.vue 97.29% <100%> (ø) ⬆️
src/components/pagination/Pagination.vue 47.05% <100%> (ø) ⬆️
src/components/table/Table.vue 13.2% <100%> (ø) ⬆️
src/components/tabs/Tabs.vue 35.29% <100%> (ø) ⬆️
src/components/dialog/Dialog.vue 46.34% <100%> (ø) ⬆️
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3ddcd6e...1871c7e. Read the comment docs.

@jtommy jtommy merged commit 03c9651 into dev Aug 8, 2018
@sinanerdem
Copy link

Thank you for the commit. I want to test the dev version. How to use tree picking? How to import a specific component?

And also I am trying to install dev branch as:
npm i -D buefy/buefy#dev
Is it correct?

@jtommy jtommy deleted the build branch August 8, 2018 16:15
@jtommy
Copy link
Member Author

jtommy commented Aug 8, 2018

@sinanerdem Docs in the dev branch has been updated and you might follow it.
For example:

import Vue from 'vue'
import Table from 'buefy/dist/components/table'
import Input from 'buefy/dist/components/input'
import 'buefy/dist/buefy.css'
Vue.use(Table)
Vue.use(Input)

To install an unpublished package I usually use:
npm install username/repo#branchName --save

@rafaberaldo
Copy link
Member

Try installing with

npm install buefy@beta

Should have this version with new build settings.

@sinanerdem
Copy link

Thank you. Everything seems to work except dialog. Its usage is a bit different. How can I use it?

@sinanerdem
Copy link

sinanerdem commented Aug 10, 2018

This works for dialog and similar components:

import Dialog from 'buefy/src/components/dialog';
Vue.prototype.$dialog = Dialog;

use inside another component as:
this.$dialog.alert("a message");

@jtommy
Copy link
Member Author

jtommy commented Aug 10, 2018

Did you add Vue.use(Dialog) and then this.$dialog. ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants