Persist options on deactivation, drop only on uninstall #26

Merged
merged 1 commit into from Sep 16, 2013

Projects

None yet

2 participants

@mpeshev
Contributor
mpeshev commented Sep 16, 2013

It's a common practice to regularly disable all plugins to check something and then activate them back. In my experience all plugins drop their custom data on uninstall only as it's annoying to have to enter all options all over again after a re-activation.

Proposal is using a separate callback for uninstall and just flushing the caps on deactivation.

@bueltge bueltge merged commit 553488b into bueltge:master Sep 16, 2013
Owner
bueltge commented Sep 16, 2013

nice and now a better code. thanks a lot.

@mpeshev mpeshev deleted the mpeshev:mpdeactivate branch Sep 16, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment