Skip to content

Commit

Permalink
Complete deletion of protoc-gen-buf-check-breaking and protoc-gen-buf…
Browse files Browse the repository at this point in the history
…-check-lint (#530)
  • Loading branch information
bufdev committed Sep 9, 2021
1 parent 48b39d7 commit b8898ab
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 100 deletions.
2 changes: 0 additions & 2 deletions .dockerignore
Expand Up @@ -6,8 +6,6 @@
.vscode/
cmd/buf/buf
cmd/protoc-gen-buf-breaking/protoc-gen-buf-breaking
cmd/protoc-gen-buf-check-breaking/protoc-gen-buf-check-breaking
cmd/protoc-gen-buf-check-lint/protoc-gen-buf-check-lint
cmd/protoc-gen-buf-lint/protoc-gen-buf-lint
private/buf/cmd/buf/cache/
private/buf/cmd/buf/command/protoc/internal/protoc-gen-insertion-point-receiver/protoc-gen-insertion-point-receiver
Expand Down
2 changes: 0 additions & 2 deletions .gitignore
Expand Up @@ -6,8 +6,6 @@
/.vscode/
/cmd/buf/buf
/cmd/protoc-gen-buf-breaking/protoc-gen-buf-breaking
/cmd/protoc-gen-buf-check-breaking/protoc-gen-buf-check-breaking
/cmd/protoc-gen-buf-check-lint/protoc-gen-buf-check-lint
/cmd/protoc-gen-buf-lint/protoc-gen-buf-lint
/private/buf/cmd/buf/cache/
/private/buf/cmd/buf/command/protoc/internal/protoc-gen-insertion-point-receiver/protoc-gen-insertion-point-receiver
Expand Down
15 changes: 14 additions & 1 deletion CHANGELOG.md
Expand Up @@ -2,7 +2,20 @@

## [Unreleased]

- No changes yet.
Complete deletion `protoc-gen-buf-check-breaking` and `protoc-gen-buf-check-lint`, which have been moved to `protoc-gen-buf-breaking` and `protoc-gen-buf-lint`.

In January 2021, `protoc-gen-buf-check-breaking` and `protoc-gen-buf-check-lint` were deprecated and scheduled for removal for v1.0. In August 2021, we began returning error for every invocation of `protoc-gen-buf-check-breaking` and `protoc-gen-buf-check-lint`. As v1.0 is imminent, this release completes the deletion process.

The only migration necessary is to change your installation and invocation from `protoc-gen-buf-check-breaking` to `protoc-gen-buf-breaking` and `protoc-gen-buf-check-lint` to `protoc-gen-buf-lint`. These can be installed in the exact same manner, whether from GitHub Releases, Homebrew, AUR, or direct Go installation:

```
# instead of go get github.com/bufbuild/buf/cmd/protoc-gen-buf-check-breaking
go get github.com/bufbuild/buf/cmd/protoc-gen-buf-breaking
# instead of curl -sSL https://github.com/bufbuild/buf/releases/download/v0.57.0/protoc-gen-buf-check-breaking-Linux-x86_64
curl -sSL https://github.com/bufbuild/buf/releases/download/v0.57.0/protoc-gen-buf-breaking-Linux-x86_64
```

There is no change in functionality.

## [v0.56.0]

Expand Down
45 changes: 0 additions & 45 deletions cmd/protoc-gen-buf-check-breaking/main.go

This file was deleted.

45 changes: 0 additions & 45 deletions cmd/protoc-gen-buf-check-lint/main.go

This file was deleted.

2 changes: 0 additions & 2 deletions make/buf/all.mk
Expand Up @@ -6,8 +6,6 @@ GO_BINS := $(GO_BINS) \
cmd/buf \
cmd/protoc-gen-buf-breaking \
cmd/protoc-gen-buf-lint \
cmd/protoc-gen-buf-check-breaking \
cmd/protoc-gen-buf-check-lint \
private/bufpkg/bufprotoplugin/cmd/protoc-gen-go-api \
private/bufpkg/bufprotoplugin/cmd/protoc-gen-go-apiclient \
private/bufpkg/bufprotoplugin/cmd/protoc-gen-go-apiclientgrpc \
Expand Down
4 changes: 1 addition & 3 deletions make/buf/scripts/release.bash
Expand Up @@ -95,9 +95,7 @@ for os in Darwin Linux Windows; do
for binary in \
buf \
protoc-gen-buf-breaking \
protoc-gen-buf-lint \
protoc-gen-buf-check-breaking \
protoc-gen-buf-check-lint; do
protoc-gen-buf-lint; do
CGO_ENABLED=0 GOOS=$(goos "${os}") GOARCH=$(goarch "${arch}") \
go build -a -ldflags "-s -w" -trimpath -o "${dir}/bin/${binary}${extension}" "${DIR}/cmd/${binary}/main.go"
cp "${dir}/bin/${binary}${extension}" "${binary}-${os}-${arch}${extension}"
Expand Down

0 comments on commit b8898ab

Please sign in to comment.