Update test case for empty dir hash in gen dir #1024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfridman
commented
Jan 24, 2024
| @@ -37,7 +37,7 @@ type Plugin struct { | |||
| } | |||
|
|
|||
| func (p *Plugin) String() string { | |||
| return fmt.Sprintf("%s:%s", p.Identity.IdentityString(), p.Version) | |||
| return fmt.Sprintf("%s:%s", p.Identity.IdentityString(), p.PluginVersion) | |||
There was a problem hiding this comment.
Version here is v1 of the config, it should be the plugin version.
mfridman
changed the title
pkwarren
reviewed
Jan 24, 2024
| @@ -37,7 +37,7 @@ type Plugin struct { | |||
| } | |||
|
|
|||
| func (p *Plugin) String() string { | |||
| return fmt.Sprintf("%s:%s", p.Identity.IdentityString(), p.Version) | |||
| return fmt.Sprintf("%s:%s", p.Identity.IdentityString(), p.PluginVersion) | |||
| // plugins. | ||
| allowedEmptyPluginSums = map[string]bool{ | ||
| "buf.build/bufbuild/validate-java": true, | ||
| "buf.build/grpc-ecosystem/gateway": true, |
There was a problem hiding this comment.
Do we want to add an exception for thebuf.build/community/mercari-grpc-federation plugin for now until a fix is made available (at least for the current version)?
There was a problem hiding this comment.
I want to undo and remove that plugin entirely, and re-open the issue advocating for an upstream fix. Any concerns with that?
It'll eliminate a broken plugin, and we also don't know if they'll fix it upstream. So best to remove and re-open issue imo.
pkwarren
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a defensive check in our plugin tests to avoid passing plugins that generate no code and produce an "empty dir" hash.
There is a historical allowlist of plugins we'll allow, but moving forward we should craft protos to exercise valid code generation, in a similar way as:
https://github.com/bufbuild/plugins/blob/d524f5ffe0e922ac10752db571b60a320f7fc7f4/tests/plugins_test.go#L133-L13
For context, this would help catch #1017 against the typical images we pass in testing.