Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Daemon support #180

Closed
buger opened this issue Jul 30, 2015 · 2 comments
Closed

Daemon support #180

buger opened this issue Jul 30, 2015 · 2 comments
Labels
enhancement New feature or feature request

Comments

@buger
Copy link
Owner

buger commented Jul 30, 2015

Currently Gor do not support demonizing natively, there is lot room for improvement.

/cc #179

@holyjak
Copy link
Contributor

holyjak commented Aug 4, 2015

It is worth mentioning (for those who stumble upon this issue) that Gor can be daemonized easily via http://www.libslack.org/daemon/

@buger buger added the enhancement New feature or feature request label Sep 1, 2015
@buger
Copy link
Owner Author

buger commented May 11, 2016

I like Sidekiq approach and agree with this https://www.mikeperham.com/2015/07/16/sidekiq-and-upstart/

  • We don’t need to daemonize. Modern daemons should never daemonize themselves.
  • We don’t need PID files. PID files are legacy from years ago and their use should signal that something is wrong.
  • We don’t need to specify our own log files. App will output to stdout; Upstart will direct stdout to a file within /var/log/upstart/ and automatically rotate those log files for you - no logrotate setup necessary!

In other words, stop reinventing the wheel and let the operating system do the hard work for you! I hope this makes your Sidekiq deployment cleaner and more stable.

@buger buger closed this as completed May 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or feature request
Projects
None yet
Development

No branches or pull requests

2 participants