Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More robust chunked encoding finished check. #628

Merged
merged 1 commit into from Feb 16, 2019

Conversation

bruce34
Copy link
Contributor

@bruce34 bruce34 commented Dec 18, 2018

Fix for infrequent false positive seeing the end of chunks in production. Obviously it isn't foolproof, but it is significantly better in our use case.

@buger buger merged commit 279aa3f into buger:master Feb 16, 2019
@zerray
Copy link

zerray commented Mar 21, 2019

For my case, this change will cause some of the Elasticsearch queries not been captured (the last packet is "0\r\n\r\n").
Can we make this into a cmd option?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants