Skip to content

Replaced _run recursive call with a while loop. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2014
Merged

Replaced _run recursive call with a while loop. #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 19 additions & 18 deletions src/PHPVideoToolkit/ExecBuffer.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -230,25 +230,26 @@ public function getRunTime()
*/
protected function _run($callback)
{
// get the buffer regardless of wether or not there is a callback as it updates and
// checks for the completion of the command.
$buffer = $this->getBuffer();

// get the buffer to give to the
if($callback !== null && is_callable($callback) === true)
{
call_user_func($callback, $this, $buffer, false);
}

// if we have finished running the loop then break here.
if($this->_running === false)
{
return;
while($this->_running !== false) {
// get the buffer regardless of wether or not there is a callback as it updates and
// checks for the completion of the command.
$buffer = $this->getBuffer();

// get the buffer to give to the
if($callback !== null && is_callable($callback) === true)
{
call_user_func($callback, $this, $buffer, false);
}

// if we have finished running the loop then break here.
if($this->_running === false)
{
break;
}

// still running so wait and then run again.
$this->wait($this->_callback_period_interval);
}

// still running so wait and then run again.
$this->wait($this->_callback_period_interval);
$this->_run($callback);
}

/**
Expand Down