Permalink
Browse files

fix [2483384] logcat crash when malloc debug is enabled

fix a couple of uninitialized variables

Change-Id: I1f7552ecb20d85dbf0fec5cae9778a70ff9281a2
  • Loading branch information...
1 parent 8d2f91d commit 50844525a31fa41d7d432efb3c0355b38adb2f5f Mathias Agopian committed Mar 17, 2010
Showing with 3 additions and 2 deletions.
  1. +3 −2 logcat/logcat.cpp
View
@@ -66,6 +66,7 @@ struct log_device_t {
device = d;
binary = b;
label = l;
+ queue = NULL;
next = NULL;
printed = false;
}
@@ -158,7 +159,7 @@ void printBinary(struct logger_entry *buf)
static void processBuffer(log_device_t* dev, struct logger_entry *buf)
{
- int bytesWritten;
+ int bytesWritten = 0;
int err;
AndroidLogEntry entry;
char binaryMsgBuf[1024];
@@ -276,7 +277,7 @@ static void readLogLines(log_device_t* devices)
if (result >= 0) {
for (dev=devices; dev; dev = dev->next) {
if (FD_ISSET(dev->fd, &readset)) {
- queued_entry_t* entry = new queued_entry_t;
+ queued_entry_t* entry = new queued_entry_t();
/* NOTE: driver guarantees we read exactly one full entry */
ret = read(dev->fd, entry->buf, LOGGER_ENTRY_MAX_LEN);
if (ret < 0) {

0 comments on commit 5084452

Please sign in to comment.