Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(update): upgrade node-expat to work with NodeJs 12 #180

Merged
merged 2 commits into from Jul 2, 2019

Conversation

@p3x-robot
Copy link
Contributor

commented Jun 7, 2019

straightforward to make it to work on NodeJs 12

@c4milo

This comment has been minimized.

Copy link
Contributor

commented Jun 7, 2019

@psemme, Hi! I hope everything is great with you!
I lost access to this repo. I'm happy to keep maintaining it if someone from Buglabs can give me access again.

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 7, 2019

well, here is the other guy vish@buglabs.net , but you are on the orginazation, weird, just need to merge and push to npm

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@psemme can you talk to him via e-mail?

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 8, 2019

@psemme

This comment has been minimized.

Copy link
Member

commented Jun 8, 2019

@c4milo

This comment has been minimized.

Copy link
Contributor

commented Jun 9, 2019

@psemme, I believe so, I no longer can merge pull requests in this repo.

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

@c4milo @psemme you can just talk to GitHub about lost auth. They will help, since both of you are on the orginization...
image

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

besides for npm it is possible to solve the package issue, they are nice: support@npmjs.com.

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 10, 2019

for github you can resolve lost organization issue: https://github.com/contact

but this is weird how you cannot use it as both of you in this buglabs organization

@bugvish

This comment has been minimized.

Copy link
Member

commented Jun 10, 2019

@c4milo It appears GH changed their collaborator policy, so adding you back as a mod to this repo would come at a cost. However I'd be happy to merge this if you give me one final confirmation. Great to hear from you btw!

@p3x-robot Thank you for your contribution and patience!

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 12, 2019

@c4milo @bugvish so after you merged this change, can you publish to npm as well?

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 23, 2019

@c4milo @bugvish ping, could you guys merge and publish to npm?

@bugvish

This comment has been minimized.

Copy link
Member

commented Jun 24, 2019

@c4milo please let me know if this is okay to merge. Thanks!

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jun 24, 2019

@bugvish has already said wants to do it but lost access and would you merge and publish this small and crucial action?

@bugvish bugvish merged commit 9827264 into buglabs:master Jul 2, 2019

@bugvish

This comment has been minimized.

Copy link
Member

commented Jul 2, 2019

@c4milo please publish to npm when you get a chance. Thanks!

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jul 2, 2019

@bugvish would mind to publish to npm as well?

@Galienna

This comment has been minimized.

Copy link

commented Jul 2, 2019

Indeed, that little publish would help me a lot as well ;)

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jul 9, 2019

@bugvish @c4milo ping, thanks for the merge, would you mind to publish to npm?

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jul 26, 2019

would you allow me to maintain this package to be able to merge here and publish to npm, because it is funny, such a small issue and we cannot go forward with it.

@bugvish

This comment has been minimized.

Copy link
Member

commented Jul 26, 2019

@c4milo Can you please publish to NPM?

@p3x-robot Apologies but as @c4milo is the author/primary maintainer, I do not have npm access and must defer to him for any decisions on community maintenance.

@p3x-robot

This comment has been minimized.

Copy link
Contributor Author

commented Jul 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
5 participants
You can’t perform that action at this time.