Skip to content
This repository has been archived by the owner. It is now read-only.

(update): upgrade node-expat to work with NodeJs 12 #180

Merged
merged 2 commits into from Jul 2, 2019
Merged

(update): upgrade node-expat to work with NodeJs 12 #180

merged 2 commits into from Jul 2, 2019

Conversation

@p3x-robot
Copy link
Contributor

@p3x-robot p3x-robot commented Jun 7, 2019

straightforward to make it to work on NodeJs 12

@c4milo
Copy link
Contributor

@c4milo c4milo commented Jun 7, 2019

@psemme, Hi! I hope everything is great with you!
I lost access to this repo. I'm happy to keep maintaining it if someone from Buglabs can give me access again.

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 7, 2019

well, here is the other guy vish@buglabs.net , but you are on the orginazation, weird, just need to merge and push to npm

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 8, 2019

@psemme can you talk to him via e-mail?

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 8, 2019

Loading

@psemme
Copy link
Member

@psemme psemme commented Jun 8, 2019

Loading

@c4milo
Copy link
Contributor

@c4milo c4milo commented Jun 9, 2019

@psemme, I believe so, I no longer can merge pull requests in this repo.

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 10, 2019

@c4milo @psemme you can just talk to GitHub about lost auth. They will help, since both of you are on the orginization...
image

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 10, 2019

besides for npm it is possible to solve the package issue, they are nice: support@npmjs.com.

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 10, 2019

for github you can resolve lost organization issue: https://github.com/contact

but this is weird how you cannot use it as both of you in this buglabs organization

Loading

@bugvish
Copy link
Member

@bugvish bugvish commented Jun 10, 2019

@c4milo It appears GH changed their collaborator policy, so adding you back as a mod to this repo would come at a cost. However I'd be happy to merge this if you give me one final confirmation. Great to hear from you btw!

@p3x-robot Thank you for your contribution and patience!

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 12, 2019

@c4milo @bugvish so after you merged this change, can you publish to npm as well?

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 23, 2019

@c4milo @bugvish ping, could you guys merge and publish to npm?

Loading

@bugvish
Copy link
Member

@bugvish bugvish commented Jun 24, 2019

@c4milo please let me know if this is okay to merge. Thanks!

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jun 24, 2019

@bugvish has already said wants to do it but lost access and would you merge and publish this small and crucial action?

Loading

@bugvish bugvish merged commit 9827264 into buglabs:master Jul 2, 2019
@bugvish
Copy link
Member

@bugvish bugvish commented Jul 2, 2019

@c4milo please publish to npm when you get a chance. Thanks!

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jul 2, 2019

@bugvish would mind to publish to npm as well?

Loading

@Galienna
Copy link

@Galienna Galienna commented Jul 2, 2019

Indeed, that little publish would help me a lot as well ;)

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jul 9, 2019

@bugvish @c4milo ping, thanks for the merge, would you mind to publish to npm?

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jul 26, 2019

would you allow me to maintain this package to be able to merge here and publish to npm, because it is funny, such a small issue and we cannot go forward with it.

Loading

@bugvish
Copy link
Member

@bugvish bugvish commented Jul 26, 2019

@c4milo Can you please publish to NPM?

@p3x-robot Apologies but as @c4milo is the author/primary maintainer, I do not have npm access and must defer to him for any decisions on community maintenance.

Loading

@p3x-robot
Copy link
Contributor Author

@p3x-robot p3x-robot commented Jul 28, 2019

Loading

@xamgore
Copy link

@xamgore xamgore commented Dec 17, 2019

@c4milo could you please publish this version to npm?

"node-expat": "^2.3.15"
— the current version can't be used with node.js ≥12

https://www.npmjs.com/package/xml2json

Loading

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

6 participants