Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent potential lifecycle breadcrumb crash #300

Merged
merged 3 commits into from Apr 30, 2018

Conversation

Projects
None yet
4 participants
@fractalwrench
Copy link
Contributor

fractalwrench commented Apr 25, 2018

Change SessionTracker to ignore exceptions when creating lifecycle breadcrumb before a client is fully constructed. This uses the same logic as EventReceiver.

fix: prevent lifecycle breadcrumb crash
change sessiontracker to ignore exception when creating lifecycle breadcrumb before client fully
constructed - uses same logic as eventrec eiver

@fractalwrench fractalwrench requested a review from bugsnag/platforms Apr 25, 2018

@coveralls

This comment has been minimized.

Copy link

coveralls commented Apr 25, 2018

Coverage Status

Coverage increased (+1.1%) to 75.439% when pulling 33257a3 on swallow-lifecycle-breadcrumb-exc into 46e0d23 on master.

@kattrali
Copy link
Member

kattrali left a comment

Approved pending a matching test

test: add lifecycle breadcrumb crash test
adds a test that checks no crash occurs if a breadcrumb is left in response to an activity lifecycle
callback, before the client can be initialised
@Cawllec
Copy link
Contributor

Cawllec left a comment

Verified the test fails before the PR, and now passes.

@fractalwrench

This comment has been minimized.

Copy link
Contributor Author

fractalwrench commented Apr 26, 2018

@Cawllec Github seems to automatically dismiss approvals whenever there's a push - I've added a JavaDoc comment to address a checkstyle warning in the test. May be best to wait until Travis completes

@fractalwrench fractalwrench changed the base branch from master to next Apr 30, 2018

@fractalwrench fractalwrench merged commit 31bd398 into next Apr 30, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+1.1%) to 75.439%
Details

@fractalwrench fractalwrench deleted the swallow-lifecycle-breadcrumb-exc branch Apr 30, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.