Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: serialise breadcrumb message correctly #306

Merged
merged 2 commits into from May 2, 2018

Conversation

Projects
None yet
4 participants
@fractalwrench
Copy link
Contributor

commented May 1, 2018

The breadcrumb message should be serialised as part of the metadata, not as the name attribute.

fix: serialise breadcrumb message correctly
the breadcrumb message should be serialised as part of the metadata, not as the name attribute

@fractalwrench fractalwrench requested a review from bugsnag/platforms May 1, 2018

@fractalwrench

This comment has been minimized.

Copy link
Contributor Author

commented May 1, 2018

Partially addresses #291

@coveralls

This comment has been minimized.

Copy link

commented May 1, 2018

Coverage Status

Coverage decreased (-0.01%) to 75.559% when pulling 268250e on breadcrumb-name-fix into feb5925 on master.

@coveralls

This comment has been minimized.

Copy link

commented May 1, 2018

Coverage Status

Coverage increased (+0.5%) to 76.078% when pulling 3711566 on breadcrumb-name-fix into 31cb452 on master.

assertEquals("Hello World", breadcrumb.getMetadata().get("message"));
}
}
assertEquals(1, count);

This comment has been minimized.

Copy link
@Cawllec

Cawllec May 1, 2018

Contributor

Is the count necessary for this test? And if so, is the for loop the best way to test for it? Would testing the length of the queue be more clear?

This comment has been minimized.

Copy link
@fractalwrench

fractalwrench May 1, 2018

Author Contributor

The size and order of the breadcrumb queue cannot be guaranteed when calling client#leaveBreadcrumb, as automatic breadcrumbs may occur at any time (around 6-7 tend to be recorded in practice).

This comment has been minimized.

Copy link
@Cawllec

Cawllec May 1, 2018

Contributor

Ah, fair enough.

@Cawllec

Cawllec approved these changes May 1, 2018

@kattrali kattrali merged commit 8a24ac6 into master May 2, 2018

3 checks passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
coverage/coveralls Coverage increased (+0.3%) to 76.078%
Details

@kattrali kattrali deleted the breadcrumb-name-fix branch May 2, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.